fix(macos): enhance deployment and packaging for macOS#2158
Open
theangelperalta wants to merge 2 commits intolem-project:mainfrom
Open
fix(macos): enhance deployment and packaging for macOS#2158theangelperalta wants to merge 2 commits intolem-project:mainfrom
theangelperalta wants to merge 2 commits intolem-project:mainfrom
Conversation
- Add automatic .icns icon generation from PNG in Makefile - Skip desktop integration install on macOS (Darwin-specific) - Copy .icns file to app bundle during deployment - Configure deploy library to exclude optional tree-sitter libraries from bundling (they're loaded at runtime when available) These changes improve macOS app packaging by: 1. Generating proper .icns icons for dock/taskbar display 2. Avoiding Linux-specific desktop file installations on macOS 3. Preventing tree-sitter library bundling issues on macOS
Contributor
|
✅ Code Contractor Validation: PASSED ℹ️ 1 violation(s) dismissed 📚 About Code ContractorDeclarative Code Standards That Learn and Improve Define domain-specific validation rules in YAML. Want this for your repo? |
![code-contractor-app[bot]](https://avatars.githubusercontent.com/in/2165592?s=60&v=4){kind=small}
code-contractor-app
Bot
dismissed
their stale review
All violations have been dismissed via resolved conversations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves macOS deployment and packaging:
make icnstarget to generate macOS.icnsicon from PNG, and copy it into the app bundle during deploymentmake installnow skips Linux desktop integration steps on macOS